Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 28, 2025

Summary
This PR adds comprehensive test coverage for the tool calling observation components in Spring AI, ensuring robust monitoring and tracing capabilities for AI tool interactions.

Changes

DefaultToolCallingObservationConventionTests: Added tests for observation convention behavior including:

  • Verification of all standard low cardinality keys presence
  • Null context handling
  • Consistency validation across multiple calls

ToolCallingContentObservationFilterTests: Added tests for observation filter functionality including:

  • Empty string handling for tool call arguments and results
  • Idempotency verification when filter is applied multiple times
  • High cardinality key value validation

ToolCallingObservationContextTests: Added tests for observation context including:

  • Empty string handling for tool arguments
  • Null and empty string handling for tool call results
  • Tool definition getter verification

Test Coverage Areas

  • Edge cases (null, empty strings)
  • Consistency and idempotency
  • Key-value pair generation
  • Context building and access patterns

Related Issues

  • Improves observability testing for AI tool calling operations
  • Ensures reliability of monitoring and tracing infrastructure

…mponents

Signed-off-by: Oleksandr Klymenko <[email protected]>

Co-authored-by: Oleksandr Klymenko <[email protected]>
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 28, 2025
@sobychacko sobychacko merged commit 09f6c6c into spring-projects:main Aug 28, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants